Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect: React Query #39036

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Protect: React Query #39036

merged 1 commit into from
Sep 9, 2024

Conversation

nateweller
Copy link
Contributor

@nateweller nateweller commented Aug 22, 2024 •
edited
Loading

Proposed changes:

  • Adds React Query
  • Removes Redux

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

https://github.com/Automattic/jetpack-scan-team/issues/1382

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Note: using your local development environment to test this PR will allow you to view the React Query developer tools via a floating icon on the bottom right of the screen.

Monitor the network tab for the duration of your testing. Ensure no async requests are triggered on page load (data comes from initial state), request polling occurs for in-progress scans and fixers, and related data is refreshed after actions are made (i.e. refresh scan status after ignoring a threat).

  • Test all the things:
    • Install on a brand new site, activate the free plan.
    • Review your initial Protect report.
    • Install a vulnerable plugin or two, review your second report (re-trigger a second free report from Jetpack Debug).
    • Activate the firewall, configure and test brute force protection and the IP lists.
    • Upgrade your plan.
    • Review the new scan report.
    • Add more threats to your site with the Jetpack Debug Helper plugin.
    • Manually start a new scan.
    • Ignore some threats, verify they are moved to history.
    • Auto-fix some threats, add credentials along the way.
    • Activate and test automatic firewall rules (i.e. ensure a request including ?foo=<script> in the URL is blocked when automatic rules are enabled).

@nateweller nateweller self-assigned this Aug 22, 2024
@github-actions github-actions bot added the [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. label Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Protect plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/protect/tanstack-query branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/protect/tanstack-query

    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protect/tanstack-query

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@nateweller nateweller force-pushed the add/protect/tanstack-query branch 2 times, most recently from 798bd3c to 672be6f Compare August 23, 2024 18:14
@github-actions github-actions bot added the Docs label Aug 23, 2024
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from 672be6f to 7cd0e22 Compare August 23, 2024 20:10
@nateweller nateweller requested a review from a team August 23, 2024 20:13
@nateweller nateweller force-pushed the add/protect/tanstack-query branch 4 times, most recently from 5203dab to 3cc7ee0 Compare August 26, 2024 16:57
@github-actions github-actions bot added the [Package] Jetpack mu wpcom WordPress.com Features label Aug 26, 2024
@nateweller nateweller force-pushed the add/protect/tanstack-query branch 15 times, most recently from 6b2f6a2 to 748eeb1 Compare August 28, 2024 06:34
@nateweller nateweller added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Aug 29, 2024
@github-actions github-actions bot added the Docs label Aug 29, 2024
@nateweller nateweller force-pushed the add/protect/tanstack-query branch 20 times, most recently from 160323a to a294482 Compare September 5, 2024 19:21
@nateweller nateweller force-pushed the add/protect/tanstack-query branch from a294482 to 06dfbb4 Compare September 7, 2024 18:38
@nateweller nateweller added the Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. label Sep 7, 2024
dkmyta
dkmyta approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@dkmyta dkmyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dkmyta dkmyta merged commit e8f5e99 into trunk Sep 9, 2024
74 checks passed
@dkmyta dkmyta deleted the add/protect/tanstack-query branch September 9, 2024 16:51
gogdzl pushed a commit that referenced this pull request Oct 25, 2024
@nateweller @gogdzl
Protect: React Query (#39036)
3793569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkmyta dkmyta dkmyta approved these changes

Assignees

@nateweller nateweller

Labels
Docs [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nateweller @dkmyta